GTFS-RT > Trip Updates > try to fix wrong stop sequence when trip stop passed once & keep all cancelled trips/stops

[mmathieum]

No description provided.

[Copilot]

⚠️ Not ready to approve

New fixStopSequence() behavior is not covered by unit tests and there are a few correctness/consistency issues in the touched logging/tag code that should be addressed before approval.

Pull request overview

This PR updates the GTFS-RT Trip Updates processing to better handle feeds where stop sequences can be wrong (attempting to correct them when the stop is encountered only once) and to retain cancelled trips/stops by treating “cancelled” similarly to “real-time” for downstream filtering/cleanup.

Changes:

• Refactors trip schedule handling to be keyed by targetUUID and threads that through trip update processing.
• Adds fixStopSequence() to rewrite/ignore StopTimeUpdates that don’t match the static stop sequence but can be mapped by stop_id.
• Updates schedule cancellation helpers to distinguish trip-level vs stop-time-level cancellation and ensures cancelled timestamps are retained in “real-time” filtering logic.

File summaries

File	Description
src/test/java/org/mtransit/android/commons/provider/status/GTFSRealTimeTripUpdatesProviderTests.kt	Adjusts tests to pass schedules as a UUID-keyed map to match updated processing API.
src/main/java/org/mtransit/android/commons/provider/status/GTFSRealTimeTripUpdatesProviderExt.kt	Refactors processing API to use schedules-by-UUID, adds stop-sequence fixing/filtering, and updates cancellation call sites.
src/main/java/org/mtransit/android/commons/provider/status/GTFSRealTimeTripUpdatesProvider.kt	Treats cancelled timestamps as “real-time” for trip retention/cleanup decisions.
src/main/java/org/mtransit/android/commons/provider/serviceupdate/GTFSRealTimeServiceAlertsProvider.kt	Exposes LOG_TAG via @JvmStatic for Java-side logging.
src/main/java/org/mtransit/android/commons/provider/GTFSRealTimeProvider.java	Routes service-alert logging through the alerts provider log tag constant.
src/main/java/org/mtransit/android/commons/data/ScheduleExt.kt	Renames and clarifies trip vs stop-time cancellation helpers and updates timestamp string formatting.
src/main/java/org/mtransit/android/commons/data/Schedule.java	Adds isRealTimeOrCancelled() helper used by Kotlin filtering logic.

Review details

• Files reviewed: 7/7 changed files
• Comments generated: 5
• Review effort level: Low

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

[Copilot]

⚠️ Not ready to approve

fixStopSequence() currently logs a warning for every ignored stop-time update, which can produce excessive noisy logs in real GTFS-RT feeds.

Review details

Comments suppressed due to low confidence (1)

src/main/java/org/mtransit/android/commons/provider/status/GTFSRealTimeTripUpdatesProviderExt.kt:214

• fixStopSequence() logs a warning for every ignored stop time update; in real GTFS-RT feeds this can happen frequently (extra/invalid STUs), so using MTLog.w here can create noisy logs and operational alerting. Consider downgrading this to debug (or sampling/throttling) since the STU is intentionally being dropped.

        MTLog.w(LOG_TAG, "fixStopSequence($tripId) > IGNORE (no stop ID/sequence match): ${stu.toStringExt()}")

• Files reviewed: 7/7 changed files
• Comments generated: 0 new
• Review effort level: Low

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.