CT-2264 NPM Connect | Unit Test Coverage 80%#337
Open
ash-wright123 wants to merge 35 commits into
Open
Conversation
ash-wright123
requested review from
Jameson13B,
codingLogan,
mwclemy and
wesrisenmay-mx
as code owners
Collaborator
|
We need to break this into smaller PRs. Given our slow CI/CD probably ~1500 line PRs is the sweet spot. We can do one at a time until we've got all these changes in. |
| import { STEPS } from 'src/const/Connect' | ||
| import PostMessage from 'src/utilities/PostMessage' | ||
|
|
||
| vi.mock('src/utilities/PostMessage', () => ({ |
Collaborator
There was a problem hiding this comment.
In general we don't want to be mocking our own stuff. If we can get away with not mocking and still have confidence, then that is ideal. If we must mock, then it should be at the very edge of what we control.
For Requests that's MSW. For packages that we must mock, we mock the package(but we try to find another way first).
For this, you probably need to mock window.parent.postMessage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.