Refactor: extract shared logic, split large files, deduplicate readers#1
Open
napinoco wants to merge 1 commit into
Open
Refactor: extract shared logic, split large files, deduplicate readers#1napinoco wants to merge 1 commit into
napinoco wants to merge 1 commit into
Conversation
Phase 1 - Solver pipeline extraction:
- New solvePOPpipeline.m consolidates BBPOPtoCOP + solveCOP setup
shared by solvePOParrow, solvePOPchordal, solvePOPdense (~30 lines each)
Phase 2 - genPOPchordal.m decomposition (528 → ~60 lines):
- findChordalCliques.m: Cholesky-based maximal clique finder (renamed from
private genCliques to avoid conflict with relaxation/genCliques.m)
- generateSparseGraph.m: sensor network graph generator with computeDistance2
as a local helper
Phase 3 - BBPOPtoCOP.m decomposition (378 → ~150 lines):
- genPolyCone.m: polynomial cone generation pipeline
- addSlack.m: slack variable insertion for Lagrangian-DNN
- findCommonMonos.m: unique monomial collection across moment/poly structures
- Removed dead code: estimateUbdIX (superseded by estimateUbdIXpd)
Phase 4 - Common file reader + deprecation fix:
- util/readInstanceFile.m: unified fopen/fscanf/fclose/sscanf pattern
- Applied to qapread, qapreadBP, qapreadnal, biqread
- Replaced deprecated findstr with strfind in qapreadnal and biqread
https://claude.ai/code/session_01HNNcizLCaDBSx3xHWoTD3F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 - Solver pipeline extraction:
shared by solvePOParrow, solvePOPchordal, solvePOPdense (~30 lines each)
Phase 2 - genPOPchordal.m decomposition (528 → ~60 lines):
private genCliques to avoid conflict with relaxation/genCliques.m)
as a local helper
Phase 3 - BBPOPtoCOP.m decomposition (378 → ~150 lines):
Phase 4 - Common file reader + deprecation fix:
https://claude.ai/code/session_01HNNcizLCaDBSx3xHWoTD3F