Skip to content

Use new nash-rust http client for place_order and cancel_order#159

Merged
notdanilo merged 11 commits into
nash-io:masterfrom
MarginUG:nash-rust-http-and-fixes
Jan 22, 2021
Merged

Use new nash-rust http client for place_order and cancel_order#159
notdanilo merged 11 commits into
nash-io:masterfrom
MarginUG:nash-rust-http-and-fixes

Conversation

@notonamap

@notonamap notonamap commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

Contents:

  • move place_order and cancel_order to nash-rust http client because of timeouts on websockets
  • upgrade to tokio 1.0 to be in sync with the new nash-rust version
  • include Ethan's sign_states_loop Nash parameter
  • remove a bit of legacy margin code from websockets
  • order_status param as a filter for order history if supported

once this gets merged we can probably close these:

and on nash-rust:

@notonamap
notonamap force-pushed the nash-rust-http-and-fixes branch from c6a3e3e to a94b494 Compare January 21, 2021 23:04
@notonamap
notonamap force-pushed the nash-rust-http-and-fixes branch from a94b494 to d646d85 Compare January 21, 2021 23:09
@notdanilo
notdanilo merged commit d646d85 into nash-io:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants