Require authorization before disabling biometrics - #100
Open
Jim8y wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a wallet authorization gate to the “Disable biometrics” flow so that deleting the stored biometric credential only happens after explicit user authorization, and cancellation/denial keeps biometrics enabled.
Changes:
- Inject
WalletAuthorizationServiceintoDisableBiometricPage. - Require authorization before deleting
biometric/credential, and bail out on cancel/deny.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
11
to
15
| readonly ApplicationDbContext dbContext; | ||
| readonly WalletAuthorizationService authorizationService; | ||
|
|
||
| public DisableBiometricPage(ApplicationDbContext dbContext) | ||
| public DisableBiometricPage(ApplicationDbContext dbContext, WalletAuthorizationService authorizationService) | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation