Skip to content

Prevent submit reentry while busy - #99

Open
Jim8y wants to merge 1 commit into
neoorder:masterfrom
Jim8y:codex/prevent-submit-reentry
Open

Prevent submit reentry while busy#99
Jim8y wants to merge 1 commit into
neoorder:masterfrom
Jim8y:codex/prevent-submit-reentry

Conversation

@Jim8y

@Jim8y Jim8y commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • ignore spinner button clicks while the control is already in its busy state
  • prevent async submit handlers from being invoked again before the previous operation finishes

Validation

  • MD_APPLE_SDK_ROOT=/Applications/Xcode-26.5.0.app dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:EnableCodeSigning=false -p:CodesignKey= -p:CodesignProvision= -p:ProvisioningType=automatic
  • dotnet test OneGate.DebugProtocol.Tests/OneGate.DebugProtocol.Tests.csproj

Copilot AI review requested due to automatic review settings July 24, 2026 18:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents SpinnerButton click reentry by ignoring click events while the control is already in its busy state, helping ensure async submit handlers aren’t invoked concurrently.

Changes:

  • Add a guard in SpinnerButton’s click handler to no-op when IsBusy is true.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants