build: cargo update and vergen 8 -> vergen-gitcl 10#44
Conversation
- Replace vergen 8 (EmitBuilder) with vergen-gitcl 10 (Emitter + Gitcl::all_git()) - Git env var names (VERGEN_GIT_SHA, VERGEN_GIT_COMMIT_DATE) unchanged - All 75 tests pass, output identical to master build across 24 BBL test files
Bump time 0.3.51 -> 0.3.53 and time-macros 0.2.30 -> 0.2.31 via cargo update. Verified: cargo build --release and cargo test --release pass; output of the new binary is byte-identical to the pre-update binary across 5 EMUF*.BBL, 1 BTFL*.BBL, and 2 BTFL*.bfl blackbox logs (headers.csv, .csv, and .event exports, with --gpx --event enabled). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe build dependency ChangesVergen to vergen-gitcl migration
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai, analyze if the vergen changes are correct/proper. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
cat -n build.rs
echo "----"
cat -n Cargo.toml | sed -n '1,60p'
echo "----"
fd Cargo.lock -x grep -n -A3 'name = "vergen' {}Length of output: 2422 🤖 web_search executed:
Length of output: 9672
Why it's correct:
Functionally, Overall: no correctness issues, this is a clean and idiomatic migration to ✏️ Learnings added
|
AI Generated pull-request ## Summary - The `vergen` 8 -> `vergen-gitcl` 10 migration (#44) switched `build.rs` from `EmitBuilder::git_sha(true)` (short SHA) to `Gitcl::all_git()`, which emits the full 40-char `VERGEN_GIT_SHA` instead. - Regression: `bbl_parser --version` now prints the full SHA (`bbl_parser 1.0.1 76b67b5 (2026-07-02)`) instead of the short one used since 1.0.0 (`bbl_parser 1.0.0 03b87d3 (2025-12-30)`). - Fix: `Gitcl::all().sha(true).build()` keeps all other `VERGEN_GIT_*` instructions enabled while restoring short-SHA output (`Gitcl::builder().all()` is a private crate-internal method, so `Gitcl::all()` is the public equivalent). ## Test plan - [x] `cargo build --release` and `cargo test --release` pass (19 unit/integration tests + 3 doc-tests) - [x] `bbl_parser --version` now prints a 7-char short SHA (e.g. `61448ef`) Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
AI Generated pull-request
Summary
cargo update: broad dependency bump across the tree (clap 4.5.40 -> 4.6.1, serde 1.0.140 -> 1.0.150, regex 1.11.1 -> 1.12.4, syn 2.0.103 -> 2.0.118, time 0.3.47 -> 0.3.53, libc 0.2.173 -> 0.2.186, and others), plus new transitive deps (bon,bon-macros,darling,darling_core,darling_macro,ident_case,prettyplease).vergen8 ->vergen-gitcl10: replacedEmitBuilder/git_sha/git_commit_datewithEmitter/Gitcl::all_git()inbuild.rsandCargo.toml.VERGEN_GIT_SHA/VERGEN_GIT_COMMIT_DATEenv var names are unchanged, so no downstream code changes were needed.Test plan
cargo build --releaseandcargo test --releasepass (19 unit/integration tests + 3 doc-tests)