Skip to content

fix: move --repo/--clobber inside find -exec command#48

Merged
nerdCopter merged 1 commit into
masterfrom
fix/release-asset-upload
Jul 2, 2026
Merged

fix: move --repo/--clobber inside find -exec command#48
nerdCopter merged 1 commit into
masterfrom
fix/release-asset-upload

Conversation

@nerdCopter

Copy link
Copy Markdown
Owner

AI Generated pull-request

Summary

  • find release-artifacts -name "*.zip" -type f -exec gh release upload "${{ github.ref_name }}" {} \; --repo "${{ github.repository }}" --clobber terminates the -exec command at \; and passes --repo/--clobber as additional find predicates, which find rejects (find: unknown predicate --repo'), failing the step with exit 1 before gh` ever runs.
  • Confirmed live: this broke the "Upload Assets to GitHub Release" job on the v1.0.1 release run (https://github.com/nerdCopter/bbl_parser/actions/runs/28620774194) — the ZIP binaries and the "Update release notes" step (gated on this step succeeding) never ran. Worked around manually for v1.0.1 by downloading the CI-built ZIPs and uploading/editing notes by hand.
  • Fix: move \; to the end so --repo and --clobber are part of the exec'd gh release upload invocation, not find arguments.

Test plan

  • Verify on the next tagged release that "Upload Assets to GitHub Release" succeeds end-to-end without manual intervention

find release-artifacts -name "*.zip" -type f -exec gh release upload
"\${{ github.ref_name }}" {} \; --repo ... --clobber

terminated the -exec command at \; and passed --repo/--clobber as
additional find predicates, which find rejects ('unknown predicate
`--repo'"), failing the "Upload release assets" step with exit 1
before it ever invoked gh. Confirmed live on the v1.0.1 release run.

Move \; to the end so --repo and --clobber are part of the exec'd gh
command.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nerdCopter, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 09a958af-4c72-4ffa-bc3a-6df53edf02ff

📥 Commits

Reviewing files that changed from the base of the PR and between 743939d and a449341.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-asset-upload

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nerdCopter nerdCopter marked this pull request as ready for review July 2, 2026 20:57
@nerdCopter nerdCopter merged commit 283c05e into master Jul 2, 2026
9 checks passed
@nerdCopter nerdCopter deleted the fix/release-asset-upload branch July 2, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant