chore(ci): harden package_for_test against untrusted PR checkout#3497
Open
zhangsoledad wants to merge 1 commit into
Open
chore(ci): harden package_for_test against untrusted PR checkout#3497zhangsoledad wants to merge 1 commit into
zhangsoledad wants to merge 1 commit into
Conversation
zhangsoledad
commented
Jul 2, 2026
zhangsoledad
commented
Member
- Require maintainer approval via package-for-test environment for issue_comment triggers.
- Do not expose GITHUB_TOKEN to packaging steps when triggered by PR comments.
- Restrict slash command to exact "/package" body.
- Use --frozen-lockfile on yarn install for PR-comment builds.
- Add SECURITY NOTE about keeping refs/pull//merge checkout.
- Require maintainer approval via package-for-test environment for issue_comment triggers. - Do not expose GITHUB_TOKEN to packaging steps when triggered by PR comments. - Restrict slash command to exact "/package" body. - Use --frozen-lockfile on yarn install for PR-comment builds. - Add SECURITY NOTE about keeping refs/pull/<n>/merge checkout.
eval-exec
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.