docs: update embedded relay coexistence with external relays#845
docs: update embedded relay coexistence with external relays#845josark2005 wants to merge 2 commits into
Conversation
…tication and external relay setup
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe documentation now explains embedded relay behavior with external relay configurations, including matching secrets, high-availability Management settings, setup alternatives, verification output, and relay metric conditions. ChangesRelay configuration documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/pages/selfhosted/maintenance/scaling/set-up-external-relays.mdxOops! Something went wrong! :( ESLint: 9.39.2 TypeError: Converting circular structure to JSON Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/selfhosted/maintenance/scaling/set-up-external-relays.mdx`:
- Line 157: The relay-selection documentation is contradictory about whether the
embedded relay is prioritized or randomly selected. Update the Option A wording
near the embedded relay description and the client relay-selection statement to
consistently document the actual behavior, explicitly noting any embedded-relay
priority exception if applicable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 20a1a042-7e6f-4f40-a550-69b6bd22e858
📒 Files selected for processing (4)
src/pages/selfhosted/maintenance/configuration-files.mdxsrc/pages/selfhosted/maintenance/scaling/high-availability.mdxsrc/pages/selfhosted/maintenance/scaling/set-up-external-relays.mdxsrc/pages/selfhosted/observability/combined.mdx
|
@coderabbitai review |
✅ Action performedReview finished.
|
Update documentation to reflect the new behavior where the embedded relay can stay
active when external relays are configured, provided
server.authSecretmatchesrelays.secret.Changes
set-up-external-relays.mdx— Rewrote the "Update Main Server Configuration"section with two options: Option A (keep embedded relay via matching
authSecretand
relays.secret) and Option B (removeauthSecret, old behavior). Updatedverification logs, STUN port guidance, and the secret-mismatch warning.
high-availability.mdx— Added a note in the Management → Relay configsection explaining that
authSecretcan be kept to leave the embedded relayrunning alongside the external relay pool.
configuration-files.mdx— Updated theserver.authSecretpropertydescription to document the new coexistence and mismatch behavior.
combined.mdx— Updated the relay metrics paragraph to note that metricsappear when the embedded relay is enabled via
authSecretmatching, not onlywhen no
relaysoverride exists.Summary by CodeRabbit
server.authSecretmatchesrelays.secret; otherwise it is disabled and logs a warning, while external relays continue to work.authSecretand configure external STUN).relay_*metrics appear (or don’t) on the combined/metricsendpoint.