feat: add on-demand memory storage and recall tools#193
Conversation
Signed-off-by: kyteinsky <kyteinsky@gmail.com> Assisted-by: Github Copilot:qwen-3-6-35b-a3b Assisted-by: Github Copilot:claude-sonnet-4-6
|
do we want specific tests for this feature in the integration tests? |
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
|
Nice! We can now make the memory tools dependent on the assistant app being installed and it should be ok |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new “Memories” toolset that lets the agent persist, browse, load, delete, and (optionally) semantically search user-scoped memory files stored under the Assistant folder in Nextcloud. It also updates TaskProcessing output validation to support the new Context Chat search output shape.
Changes:
- Added
ex_app/lib/all_tools/memory.pyimplementing memory storage/recall tools (list/load/store/delete/delete-folder/search). - Added DAV folder-creation logic to ensure the Memories base folder and subfolders exist when storing memories.
- Updated TaskProcessing output-key validation to accept
sourcesoutputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| ex_app/lib/all_tools/memory.py | Adds new memory management tools + path validation + DAV folder creation + Context Chat-backed semantic search. |
| ex_app/lib/all_tools/lib/task_processing.py | Extends accepted TaskProcessing output keys to include sources for Context Chat search results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Works nicely. I didn't test the context_chat integration though, because I don't want to set it up 😇 |
I got that covered. |
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
c002f33 to
f4f2663
Compare
|
woop woop |
needs nextcloud/context_chat#247
🤖 AI (if applicable)