fix: visualization of multiple attachments#13315
Open
madbob wants to merge 1 commit into
Open
Conversation
Signed-off-by: Roberto Guido <info@madbob.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original issue occurs on mobile, when expanding the "more attachments" area. I've introduced an explicit scrollable area that permits to navigate them.
The most invasive modification here is the change of the background color, which was a linear gradient and now is a static color. A linear gradient is proportional, and the height of the transparent portion is unpredictable as may vary accordingly to the number of attachments. With many attachments, the transparent area growns and interact badly with the overlapped contents of the message.
I've also introduced some minor adjustments to bottom buttons ("View more attachments", "Show all on Files", "Download zip") alignment on mobile.
(Don't care broken attachment previews in my screencasts: I'm breaking stuff around 😛 )
Original state:
test-original.mp4
New state:
test-mine-changes.mp4
Fixes #10408