feat(lyrics): add SPlayer source#55
Merged
Merged
Conversation
Contributor
Author
|
Hi! Thanks for the i18n cleanup on lyrics. One small nit from Current: Expected (matches the default order / SPlayer source from this PR): Functionality is fine — only the settings help text is incomplete. Happy to open a one-line PR if preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
h465855hgg/lyricsplugin.toml)What it does
Updates Lyrics to version 1.4.1 and adds an SPlayer source that reads SPlayer current final
lrcData/yrcDatathrough its local API. The adapter preserves line and word timing, translations, romanization, background lines, and duet markers. It also detects pseudo word-timed LRC lines stretched to the next timestamp so instrumental cues remain visible.External dependencies
playerctl: reads and controls MPRIS players.python3: runs the unified lyric-source adapter and dynamic lyric parser.cp: preserves local MPRIS artwork in the plugin cache.chmod: secures the temporary request directory before credentials are written.splayer_api_url(default:http://127.0.0.1:25884). SPlayer must be running when this source is used.lyrics/README.md.The command dependencies are listed in
lyrics/plugin.toml.Testing
noctalia plugins lint lyrics(0 errors, 0 warnings)python3 -m py_compile lyric_sources.py krc_decode.py lrclib_lyric.pyLive SPlayer lyric transmission test
Pseudo word-timing/interlude regression test
GitHub Actions
Validate Plugin ManifestscheckTested on Niri
Tested on Hyprland
Tested on Sway
Tested on another compositor:
Noctalia version tested against:
v5.0.0 (v5.0.0-beta.3-11-ga336b7d1b9d5)Plugin API level: 3
Screenshots / Videos
This source update does not change the visual surface. Existing screenshots remain available in
lyrics/screenshots, including the widget and settings.Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows the README template, documents every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.thumbnail.webpwith the thumbnail generator. Existing thumbnail; generation method not verified for this update.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user session. Confirm:
licensedeclared inplugin.toml.