test: verify [async] marker is structural, not a filter#87
Open
isaacs wants to merge 2 commits into
Open
Conversation
isaacs
force-pushed
the
isaacs/test-async-marker
branch
from
5b3ba56 to
5985e83
Compare
This was referenced Jun 24, 2026
This is the cleanest way to do certain things that cannot be reached by name alone. However, it's brittle to rely on a feature, even a stable one, which is not documented or tested. So, treat it as a first-class feature.
The 'functionQuery' generated variants include a '[async]' token in the generated selector. This was somewhat confusing, leading me to think that it was filtering for async functions, though this is not the case. The added test does nothing but verify the result of this investigation, and prevents our functionQuery selectors from regressing to only affecting async functions. At least, the presence of a test makes it less confusing.
isaacs
force-pushed
the
isaacs/test-async-marker
branch
from
5985e83 to
0d34514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Based on #86, land that first
The 'functionQuery' generated variants include a '[async]' token in the
generated selector. This was somewhat confusing, leading me to think that
it was filtering for async functions, though this is not the case.
The added test does nothing but verify the result of this investigation,
and prevents our functionQuery selectors from regressing to only affecting
async functions. At least, the presence of a test makes it less confusing.