Changed : refactor the way the imports of files is handled#32
Open
tdel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette PR est proposé afin d'apporter une amélioration de structure au projet existant.
Le fonctionnement du projet n'a pas changé, le point d'entrée est toujours la commande.
Cependant, le fonctionnement a changé comme suit :
L'architecture ici présente permet ainsi d'ajouter de nouveaux "parser", permettant non seulement d'implémenter des fichiers "custom" de clients mais également de disposer de plusieurs "versions", notamment lorsqu'on souhaite faire des optimisations (exemple avec le parser JSON qui a été décliné en 3 versions ici).
Un test unitaire assez simple a été effectué pour le parser JSON en v3, démontrant un cas de test relativement basique.
Points à améliorer pour plus tard :
Points à noter :