object: Allow header with payload chunk in first GET response message#333
Open
cthulhu-rider wants to merge 1 commit into
Open
object: Allow header with payload chunk in first GET response message#333cthulhu-rider wants to merge 1 commit into
cthulhu-rider wants to merge 1 commit into
Conversation
Previously, heading and chunk fields were mutually exclusive in each GET response message. With this, server sent 1st message with the header only, then messages with payload chunks came. This behavior is inefficient since any object with a non-empty payload requires one more message. The smaller the payload, the greater the overhead. This modifies GET protocol to allow header and chunk to be attached to the same message. For backward compatibility, requests from older clients will be processed as before. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Member
|
Let's get more isolated statistics for this change. It should give us something real in tests or otherwise it doesn't worth the change and versioning complexity. |
Contributor
Author
carpawell
reviewed
Jul 8, 2026
carpawell
left a comment
carpawell
left a comment
Member
There was a problem hiding this comment.
Do we have any load updates on it?
Member
|
All of the old data suggests that it's irrelevant. But it should be tried again, 4K perf has changed seriously and we also have EC now that is different in some cases. |
Member
|
I dont like the idea of such changes in API, but it is faster, we should consider it. |
Member
|
The API change can be made compatible by introducing another type for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here's an option through the proto version. It will work on the wire. The only other alternative I see is a new
GetV2call which is more demanding of support