Dist setup#9
Merged
Merged
Conversation
0.2.3 shipped a cp314-tagged platform wheel with no _rust binary inside: the try/except on setuptools_rust silently zeroed the extension list when the package was absent from the build shell, and optional=True swallowed compile failures (PyO3 0.20 couldn't target 3.14 anyway). The result installed only on the exact arch it was mistagged for and ran the Python fallback regardless. Decouple tag from build accident: - Gate the Rust extension on NSV_BUILD_RUST=1. Default build is pure and emits an honest py3-none-any wheel; the runtime try/except in core.py still falls back to Python, so end users never need Rust. - optional=False under the gate: a build that explicitly asked for Rust fails loudly instead of producing a mistagged pure wheel. - find_packages(exclude=tests*) so the test suite stops leaking into site-packages as a top-level package. - Drop zip_safe=False (forced Root-Is-Purelib: false) and the redundant setup_requires; remove setuptools-rust from unconditional build requires so the default PEP-517 build is pure. Verified on this machine: default -> py3-none-any (no binary, no tests); NSV_BUILD_RUST=1 -> cp314 wheel with nsv/_rust.so, Rust path active at runtime. Both backends agree on all 1093 nsv-tests enum fixtures and the 92MB champernowne fixed-point roundtrip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- archs=auto64: the 32-bit i686 manylinux build failed (rustup-init can't load libatomic.so.1 in that container) and isn't a target we ship. - macos-15 (arm64) + macos-15-intel (x86_64): macos-13 is retired and never schedules; keep both arches on one OS version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.