feat(base): support IRSA annotations on logs controller SA when cloudwatch enabled#157
Merged
Merged
Conversation
…watch enabled Render annotations on the nullplatform-pod-metadata-reader-sa ServiceAccount only when cloudwatch.enabled is true and cloudwatch.serviceAccount.annotations is set, so the logs controller can reach CloudWatch via a scoped IRSA role instead of the node instance role. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gdrojas
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renders
annotationson thenullplatform-pod-metadata-reader-saServiceAccount only whencloudwatch.enabledis true andcloudwatch.serviceAccount.annotationsis non-empty. Adds thecloudwatch.serviceAccount.annotationsvalue (default{}).No change for existing installs: with cloudwatch disabled or no annotations set, the SA renders exactly as before.
Why
The logs controller (
k8s-logs-controller) runs undernullplatform-pod-metadata-reader-sa. The SA had no annotations and no way to set them via values, so on EKS the controller could only reach CloudWatch through the node instance role (broad, node-wide privilege).This lets you set
eks.amazonaws.com/role-arnon the SA and use IRSA — a scoped IAM role for just the logs controller — instead of granting CloudWatch to every pod on the node.Changes
templates/serviceaccount.yaml— conditionalannotationsblock on the reader SAvalues.yaml— newcloudwatch.serviceAccount.annotations(default{}) with documented exampleREADME.md— values table entryUsage
Testing
helm templateverified in three scenarios:annotations:block (valid YAML)🤖 Generated with Claude Code