feat: re-add scheduled task nodeSelector with correct indentation#198
Merged
Conversation
fedemaleh
force-pushed
the
feat/scheduled-task-nodeselector
branch
from
July 10, 2026 02:07
5b00063 to
36c2d69
Compare
geisbruch
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds
nodeSelectorsupport for scheduled task (CronJob) scopes. This supersedes #196, which was reverted (#197) because it rendered invalid YAML and broke deployments:Root cause of the original breakage
nodeSelectoris a map, but its content was rendered atindent 10— the same column as thenodeSelector:key. That made the map entries (e.g.kubernetes.io/arch: arm64) siblings ofnodeSelector:undertemplate.specinstead of children. The neighboringtolerationsblock uses the sameindent 10and works only because it is a sequence (-markers disambiguate nesting).Fix
Render the
nodeSelectormap content atindent 12, two spaces deeper than its key (the k8s deployment template already follows this rule).Verification
Rendered the full CronJob template with the real arm64 modifier;
kubernetes.io/arch: arm64now nests correctly undernodeSelector:.Changes
scheduled_task/deployment/templates/deployment.yaml.tpl:nodeSelectorblock atindent 12.CHANGELOG.md: re-added the[Unreleased]entry removed by the revert.