Skip to content

feat: re-add scheduled task nodeSelector with correct indentation#198

Merged
geisbruch merged 1 commit into
betafrom
feat/scheduled-task-nodeselector
Jul 10, 2026
Merged

feat: re-add scheduled task nodeSelector with correct indentation#198
geisbruch merged 1 commit into
betafrom
feat/scheduled-task-nodeselector

Conversation

@fedemaleh

@fedemaleh fedemaleh commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Re-adds nodeSelector support for scheduled task (CronJob) scopes. This supersedes #196, which was reverted (#197) because it rendered invalid YAML and broke deployments:

CronJob in version "v1" cannot be handled as a CronJob: strict decoding error:
unknown field "spec.jobTemplate.spec.template.spec.kubernetes.io/arch"

Root cause of the original breakage

nodeSelector is a map, but its content was rendered at indent 10 — the same column as the nodeSelector: key. That made the map entries (e.g. kubernetes.io/arch: arm64) siblings of nodeSelector: under template.spec instead of children. The neighboring tolerations block uses the same indent 10 and works only because it is a sequence (- markers disambiguate nesting).

Fix

Render the nodeSelector map content at indent 12, two spaces deeper than its key (the k8s deployment template already follows this rule).

Verification

Rendered the full CronJob template with the real arm64 modifier; kubernetes.io/arch: arm64 now nests correctly under nodeSelector:.

Changes

  • scheduled_task/deployment/templates/deployment.yaml.tpl: nodeSelector block at indent 12.
  • CHANGELOG.md: re-added the [Unreleased] entry removed by the revert.

@fedemaleh
fedemaleh force-pushed the feat/scheduled-task-nodeselector branch from 5b00063 to 36c2d69 Compare July 10, 2026 02:07
@fedemaleh fedemaleh changed the title fix: correct nodeSelector indentation for scheduled task scopes feat: re-add scheduled task nodeSelector with correct indentation Jul 10, 2026
@geisbruch
geisbruch merged commit 3cdd965 into beta Jul 10, 2026
3 checks passed
@geisbruch
geisbruch deleted the feat/scheduled-task-nodeselector branch July 10, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants