fix: repair kill-instance scope action slug and add instance_id parameter#205
Merged
Merged
Conversation
pilundain
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The per-instance kill action for scopes was broken. It had been renamed to
kill-job-execution, a slug the API/frontend do not recognize, so the platform never injected the selected instance's context. Without adeployment_idthe action routed to the scope entrypoint and failed withfailed to read workflow file: .../scope/workflows/kill-job-execution.yaml.This PR repairs the action across all scopes (
k8s,scheduled_task,azure,azure-aro):kill-instance— the slug the API and frontend expect to render the per-instance kill button and inject the target instance. Reverts thekill-job-executionrename (and its standalone-workflow entrypoint fallback).instance_idstring parameter in each action schema. The scripts already read this field (its value is the pod name, matchingidfrominstance/list), but the schema never declared it.scheduled_taskas an override of the k8s base workflow (action: replace), so it uses its own Job→CronJob ownership check instead of the base ReplicaSet→Deployment one.Test plan
bats k8s/deployment/tests/kill_instance.bats scheduled_task/deployment/tests/kill_instance.bats→ 16/16 passbats scheduled_task/deployment/tests/workflow_overrides.bats service/deployment/tests/entrypoint.bats→ passkill-instance.json.tplspecs validated as JSON withinstance_idrequired