Skip to content

fix(appimage): ship the .zsync next to the AppImage #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvdweem merged 1 commit into from
Jul 14, 2026
Merged

fix(appimage): ship the .zsync next to the AppImage #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packaging/linux/appimage/build-appimage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,21 @@ OUT="$OUTPUT_DIR/PCPanel-${VERSION}-${ARCH}.AppImage"

echo ">> Building AppImage with $APPIMAGETOOL"
if [ -n "${UPDATE_INFO:-}" ]; then
# -u bakes the update-information into the AppImage and makes appimagetool emit "$OUT.zsync"
# alongside it (the control file the updater fetches). Both must be uploaded to the release.
# -u bakes the update-information into the AppImage and makes appimagetool emit the companion
# "<basename>.zsync" control file that the updater fetches. Both must be uploaded to the release.
echo ">> Embedding update information: $UPDATE_INFO"
"$APPIMAGETOOL" -u "$UPDATE_INFO" "$APPDIR" "$OUT"
# appimagetool writes the .zsync into the CURRENT directory (by AppImage basename), NOT next to an
# absolute $OUT — move it beside the AppImage so the artifact glob (target/*.AppImage.zsync) picks it
# up. Without this the release ships the AppImage but no .zsync, and self-update silently can't run.
zsync_basename="$(basename "$OUT").zsync"
if [ -f "$zsync_basename" ]; then
mv -f "$zsync_basename" "$OUT.zsync"
echo ">> Placed update control file at $OUT.zsync"
elif [ ! -f "$OUT.zsync" ]; then
echo ">> ERROR: appimagetool did not produce '$zsync_basename'; self-update would be broken" >&2
exit 1
fi
else
echo ">> No UPDATE_INFO set; building without self-update information"
"$APPIMAGETOOL" "$APPDIR" "$OUT"
Expand Down