fix: resolve in-container ctest script from env before importing the CLI#200
Merged
Conversation
The in-container -S argument imported holoscan_cli just to locate the ctest script, so `test` failed in images without an importable CLI even though HOLOSCAN_CLI_CTEST_SCRIPT is already forwarded into the container. Use the forwarded env value first and keep the import only as the fallback for projects that do not set it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe containerized ChangesContainer ctest script resolution
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
tbirdso
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-container
ctest -Sargument importedholoscan_clijust to locate the ctest script, sotestfailed in images without an importable CLI even thoughHOLOSCAN_CLI_CTEST_SCRIPTis already forwarded into the container. Use the forwarded env value first and keep the import only as the fallback.🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
HOLOSCAN_CLI_CTEST_SCRIPTvalue, with a fallback when it is not set.Tests