feat(cli): add docker runtime check to doctor command#149
Open
iamraydoan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a Docker runtime check to the
openship doctorCLI command. Since Openship relies heavily on Docker containers for deployment and service management, validating Docker availability during preflight checks helps developers diagnose local environment issues early before attempting builds or deployments.Changes
dockerCheck()inapps/cli/src/commands/doctor.ts:docker --versionto extract the installed Docker Engine version.docker infoto verify whether the Docker daemon is currently running.pass: Docker Engine installed AND daemon is running (27.1.2 (running)).warn: Docker installed BUT daemon is stopped (27.1.2 (installed, but daemon is not running)).warn: Docker is not installed (not installed (optional for CLI, required for container builds)).--jsonmachine-readable output.Why
Currently,
openship doctorvalidates Node.js, Bun, Config file, and API health, but completely omits Docker. If a user runsopenship deploywithout Docker running, the deploy pipeline fails downstream. Adding this check directly indoctorprovides immediate visibility.Verification & Testing
Tested locally with
bun run --cwd apps/cli buildand executed vianode apps/cli/dist/index.js doctor.Human-readable Output: