FilterButton component#101
Open
barry-observation wants to merge 3 commits into
Open
Conversation
SjaakSchilperoort
left a comment
SjaakSchilperoort
left a comment
Member
There was a problem hiding this comment.
Na discussie met Karel erop uitgekomen dat de filter button, die op Observation een icon en text size van 14 heeft, in ObsIdentify een icon en text size van 12 krijgt. Hiermee kunnen we deze library-component voor beide apps gebruiken.
| export default FilterButton | ||
|
|
||
| const createStyles = (theme: Theme) => | ||
| StyleSheet.create({ |
Member
There was a problem hiding this comment.
Note to self: ik zie dat rule react-native/no-unused-styles nog uit staat, daar zal ik een separate PR voor maken.
EDIT: #102
| <TouchableOpacity style={[styles.container, { backgroundColor }]} onPress={onPress} activeOpacity={0.5}> | ||
| <View style={styles.titleContainer}> | ||
| <View style={styles.iconContainerStyle}> | ||
| <Icon name="bars-filter" size={theme.icon.size.m} color={theme.color.icon.system.brand} /> |
Member
There was a problem hiding this comment.
Icon size en text size moeten beide 12 zijn, dus dit moet theme.icon.size.s zijn.
Contributor
Author
There was a problem hiding this comment.
Nice, goed gezien 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from the Observation app and converted to dynamic theming.