Skip to content

Fix typos. - #647

Merged
NathanReb merged 1 commit into
ocaml-ppx:mainfrom
ScythingSt:main
Jul 22, 2026
Merged

Fix typos.#647
NathanReb merged 1 commit into
ocaml-ppx:mainfrom
ScythingSt:main

Conversation

@ScythingSt

Copy link
Copy Markdown
Contributor

There are 2 typos in the documentation file examples.mld.

ppx_deriving_accesors  (old)
ppx_deriving_accessors (new)

@NathanReb NathanReb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@NathanReb

Copy link
Copy Markdown
Collaborator

You'll need to add a Signed-off-by trailer to make the DCO check happy! You can do it with a simple git rebase -s main

Signed-off-by: Zhou Junlin <asrjnadi@gmail.com>
@ScythingSt

Copy link
Copy Markdown
Contributor Author

Thank you for your suggestion!

I just noticed that even though I did sign off my real name manually in the previous commit, DCO requires me to use the same name as for Git, which was a pseudonym. Now everything should be correct.

@NathanReb

Copy link
Copy Markdown
Collaborator

Ah my bad, didn't take the time to check whether the commits were actually signed off. Anyway, thanks for fixing this, merging!

@NathanReb NathanReb added the no changelog Use this label to disable the changelog check github action label Jul 22, 2026
@NathanReb
NathanReb merged commit b9646cc into ocaml-ppx:main Jul 22, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog Use this label to disable the changelog check github action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants