fix(example): use aware web search timestamps#694
Open
Ghraven wants to merge 1 commit into
Open
Conversation
vaderollama
approved these changes
Jul 14, 2026
vaderollama
left a comment
There was a problem hiding this comment.
LGTM — replaces deprecated datetime.utcnow() with datetime.now(timezone.utc) in the web search example. Pure quality fix, no behavior change for users. Low risk.
@ParthSareen — ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime.utcnow()in the GPT-OSS web search helper example withdatetime.now(timezone.utc)Page.fetched_attype and behavior while making timestamps timezone-awareProblem
The example currently creates fetched-at timestamps with naive UTC datetimes.
datetime.utcnow()is deprecated in modern Python, and the resulting values do not carry explicit timezone information.Before / After
Before, fetched pages stored naive UTC timestamps.
After, fetched pages store UTC-aware timestamps with
timezone.utc.Verification
python -m py_compile examples/web_search_gpt_oss_helper.pygit diff --check