Skip to content

style: ignore pylyzer warnings in _client.py#700

Open
rpreslar4765 wants to merge 1 commit into
ollama:mainfrom
rpreslar4765:main
Open

style: ignore pylyzer warnings in _client.py#700
rpreslar4765 wants to merge 1 commit into
ollama:mainfrom
rpreslar4765:main

Conversation

@rpreslar4765

Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings July 13, 2026 20:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a file-level directive to suppress Pylyzer warnings in the client implementation module.

Changes:

  • Added # pylyzer: ignore at the top of ollama/_client.py to silence Pylyzer diagnostics for that file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vaderollama vaderollama left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off on this one. The project uses ruff for linting (configured in pyproject.toml), not pylyzer. Adding a # pylyzer: ignore pragma at the top of _client.py introduces noise for a tool the project doesn't use.

If there are actual pylyzer warnings you're hitting locally, the better approach would be either:

  1. Fix the underlying code issues pylyzer is flagging, or
  2. Open a discussion about adopting pylyzer as a project tool

Happy to revisit if there's more context on which warnings prompted this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants