Skip to content

Make detached attach readiness deterministic - #534

Open
omkhar wants to merge 1 commit into
mainfrom
fix/detached-attach-readiness
Open

Make detached attach readiness deterministic#534
omkhar wants to merge 1 commit into
mainfrom
fix/detached-attach-readiness

Conversation

@omkhar

@omkhar omkhar commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the detached-session invariant's fixed attach delay with a transcript-proven readiness barrier
  • wait for the live alpha and beta messages before evaluating the attach process
  • account for readiness sends in the audit timeline and reap the attach process tree on every exit path

Validation

  • ./scripts/verify-invariants.sh
  • ./scripts/dev-quick-check.sh
  • ./scripts/validate-repo.sh
  • ./scripts/pre-merge.sh --profile pr-parity
  • bash -n scripts/verify-invariants.sh
  • shellcheck -e SC1091 scripts/verify-invariants.sh
  • shfmt -ln=bash -i 2 -ci -d scripts/verify-invariants.sh
  • three peer-review lenses, all clean after fixes and re-review

Contract and scope

  • test/certification harness only; no public operator-contract change
  • PR shape: 1 file, 98 lines, 1 area, 0 binaries

Replace the fixed startup delay with transcript-proven readiness, bounded message observation, exact audit accounting, and process-tree cleanup.

The live Darwin/Colima invariant, repository validator, quick gate, mutation suite, and three peer-review lenses pass on this exact change.
@omkhar
omkhar marked this pull request as ready for review July 30, 2026 00:02
@omkhar
omkhar enabled auto-merge July 30, 2026 00:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e06092708

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/verify-invariants.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant