Restore current-track highlighting in sorted playlists - #1
Draft
oniivan wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Gem Sort intentionally uses an internal playback context so Next and Previous follow the custom sort. Spotify’s native row component compares playback context identity against the playlist route, so it no longer applied its normal current-row styling.
Impact
Sorted queue behavior remains unchanged. The added work is limited to the currently rendered rows on a song change or an existing reconciliation pass; there are no new requests, full-playlist scans, timers, or persistent storage.
Validation
npm test— 34 tests passed.npm run check— JavaScript and installer syntax passed.