feat(network, articles, workers, submission): enhance offline handling and retry mechanisms - #1481
Merged
Merged
Conversation
sdsantos
approved these changes
Jul 27, 2026
|
|
||
| private suspend fun refresh(skipIntervalCheck: Boolean) { | ||
| if (!isOnline()) { | ||
| // Expected, not a bug: no stamp of any kind, so the refresh runs as soon as a network |
Contributor
There was a problem hiding this comment.
What does "no stamp of any kind" mean? And expected to be offline?
Member
Author
There was a problem hiding this comment.
here we are checking if the device is offline first.
we dont throw an exception or anything and we know failure is the expected outcome.
…g and retry mechanisms
aanorbel
force-pushed
the
chore/better-connectivity-resilience
branch
from
July 27, 2026 12:38
3027b98 to
eddddb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.