Extract inline scripts into ConfigMaps for linting and formatting - #22
Merged
Conversation
exe-prow-github-app
Bot
added
the
approved
Move all inlined Tekton Task scripts into standalone files under rhacs/scripts/, mounted via two ConfigMaps (shell and python). Replace Tekton variable substitutions inside scripts with environment variables bridged through step env: entries. Add Kustomize configMapGenerator to auto-create ConfigMaps from the script files. Closes opdev#18 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lslavkov
force-pushed
the
linting-formatting-scripts
branch
from
July 23, 2026 12:07
cf705c0 to
7e2b2d3
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lslavkov
added
documentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lslavkov, yashoza19 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rhacs/scripts/(8 Python, 7 shell)configmaps/scripts.yaml) with two shared ConfigMaps generated via KustomizeconfigMapGenerator:rhacs-shell-scripts(defaultMode0755) — install-ocm, install-roxctl, ocm-token, test-rox-api-token, create/delete-rox-api-token-secret, scan-imagerhacs-python-scripts— authenticate-central, configure-central, destroy-central, provision-central, wait-for-central-ready/delete, wait-for-scanner-init, json-to-csvSTEP_RESULT_PATH,TASK_RESULT_PATH)rhacs/kustomization.yaml— deploy withkubectl apply -k rhacs/rhacs/configmaps/scripts.yaml(replaced by configMapGenerator)Closes #18
Test plan
kubectl kustomize rhacs/and verify all 13 resources render (2 RBAC, 2 ConfigMaps, 1 Pipeline, 7 Tasks)script:fields remain in rendered Task output🤖 Generated with Claude Code