Fix the figures reported by "Rows out" in EXPLAIN ANALYZE - #403
Open
Alena0704 wants to merge 1 commit into
Open
Conversation
Skip the segments that did not run the node instead of counting them as workers producing zero rows, report rows per loop so that rescanned nodes match their own row count, and take the segment numbers relative to the slice rather than to the insts array. Taken from GreengageDB/greengage#524, which fixed the feature while backporting it from here.
Alena0704
force-pushed
the
explain-rows-out-fixes
branch
from
July 28, 2026 14:51
9a24b91 to
c817210
Compare
Alena0704
marked this pull request as ready for review
July 28, 2026 15:36
Alena0704
marked this pull request as draft
July 28, 2026 15:48
Alena0704
marked this pull request as ready for review
July 28, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the figures reported by "Rows out" in EXPLAIN ANALYZE
Skip the segments that did not run the node instead of counting them as
workers producing zero rows, report rows per loop so that rescanned
nodes match their own row count, and take the segment numbers relative
to the slice rather than to the insts array.
Taken from GreengageDB/greengage#524, which fixed the feature while
backporting it from here.