Add AlwaysRecordSampler#5354
Open
carlosalberto wants to merge 6 commits into
Open
Conversation
carlosalberto
commented
Jun 25, 2026
| """ | ||
|
|
||
| def __init__(self, root: Sampler): | ||
| if root is None: |
Contributor
Author
There was a problem hiding this comment.
I'm tempted to remove this check as such wrapped sampler check doesn't exist in current samplers, e.g. ParentBased sampler.
carlosalberto
commented
Jun 25, 2026
| self.sampler: sampling.Sampler = sampling.AlwaysRecordSampler(self.mock_sampler) | ||
|
|
||
| def test_get_description(self): | ||
| static_sampler: sampling.Sampler = sampling.StaticSampler(sampling.Decision.DROP) |
Contributor
Author
There was a problem hiding this comment.
We don't seem to be using type hints at local variables level, so OK to remove them?
ocelotl
suggested changes
Jun 26, 2026
| return f"ParentBased{{root:{self._root.get_description()},remoteParentSampled:{self._remote_parent_sampled.get_description()},remoteParentNotSampled:{self._remote_parent_not_sampled.get_description()},localParentSampled:{self._local_parent_sampled.get_description()},localParentNotSampled:{self._local_parent_not_sampled.get_description()}}}" | ||
|
|
||
|
|
||
| class AlwaysRecordSampler(Sampler): |
| trace_state: trace.TraceState = trace.TraceState() | ||
| trace_state.add("key", root_decision.name) | ||
| root_result: sampling.SamplingResult = sampling.SamplingResult( | ||
| attributes={"key", root_decision.name}, |
Contributor
There was a problem hiding this comment.
This is a set, not a dict, maybe that's why tests are failing?
Suggested change
| attributes={"key", root_decision.name}, | |
| attributes={"key": root_decision.name}, |
github-project-automation
Bot
moved this to Reviewed PRs that need fixes
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took the initial effort of #4823 and updated it to: