fix: support kmsprint for display detection#3623
Open
Patrick-Remy wants to merge 2 commits into
Open
Conversation
Modern Raspberry Pi OS versions use kmsprint instead of deprecated tvservice.
Contributor
|
Thanks for your contribution. The use of the vc4-kms-v3d kernel module is currently not supported by openWB software2. The root cause is, that the module was still kind of buggy in the first releases of Bullseye. Switching to this kernel module requires more changes, than just using kmsprint. Setting the display rotation is currently done with the parameter "lcd_rotate" in "/boot/config.txt". This rotates the display and touch input. With the newer kms module this has to be done in another way. If you intend to add support for the kms module in this PR, please also add support for changing the display rotation. |
Contributor
Author
|
Good hint, I will add rotating support next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a fresh installation of the latest Raspberry Pi OS bullseye (https://downloads.raspberrypi.org/raspios_oldstable_lite_armhf/images/raspios_oldstable_lite_armhf-2025-05-07/) with an OpenWB Pro+, and executing the official install script, the integrated display is not detected.
This is caused as the
atreboot.shscript is using the deprecated tvservice which just printsopenwb@openwb-2:~ $ tvservice -l tvservice is not supported when using the vc4-kms-v3d driver. Similar features are available with standard linux tools such as kmsprint from kms++-utilsand therefore assumes there is no display connected. This PR tries to use the modern
kmsprintfirst and additionally should make it more compatible for upcoming bookworm and trixie support.