refactor: add typed getHttpErrorStatus helper and PlatformError type#171
refactor: add typed getHttpErrorStatus helper and PlatformError type#171dcoa wants to merge 3 commits into
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
=========================================
Coverage ? 97.55%
=========================================
Files ? 68
Lines ? 1677
Branches ? 404
=========================================
Hits ? 1636
Misses ? 41
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| }, 5000); | ||
| }; | ||
| }, DEFAULT_TOAST_DELAY); | ||
| removalTimers.current.push(timer); |
There was a problem hiding this comment.
nit: I see that the timers are being pushed to the ref at every discardToast, but they are never deleted
There was a problem hiding this comment.
I added a change for this, could you validate, please?
Summary
Consolidates the scattered request error's HTTP status into one typed helper, removing the as any / @ts-ignore / lie-to-the-compiler patterns that were duplicated across the module.
What and why
getHttpErrorStatus(error: unknown): number | undefined,which safely reads the status the auth client attaches to thrown errors.PlatformErrorinterface that return the AxiosError shape.Small clean ups
ToastManagerContextclears pending toast-removal timers on unmount and wrapsshowToast/discardToastinuseCallback(fixes a setState-after-unmount risk and a stale-closure in the context value).runRevokeRoleparam ({ data: RevokeUserRolesRequest }).AI use acknowledgement
Supported by Claude Code