Skip to content

fix: scope AdminConsoleOrgsAPIView to the user's assigned orgs#356

Open
mariajgrimaldi wants to merge 1 commit into
mainfrom
MJG/filter-orgs-by-assignments
Open

fix: scope AdminConsoleOrgsAPIView to the user's assigned orgs#356
mariajgrimaldi wants to merge 1 commit into
mainfrom
MJG/filter-orgs-by-assignments

Conversation

@mariajgrimaldi

@mariajgrimaldi mariajgrimaldi commented Jul 9, 2026

Copy link
Copy Markdown
Member

Description

The org filter endpoint returned every active org regardless of the requesting user's actual course/library role assignments. Now it's limited to orgs the user has a role in (via specific or org-level glob scopes), with staff/superusers still seeing everything.

Fixes openedx/wg-build-test-release#612

How to Test

  1. Log in as a staff/superuser and call GET /api/authz/v1/orgs/. Every active org is returned.
  2. Log in as a non-staff user with a course or library role in a specific scope, e.g. lib:Org1:LIB1, and call the same endpoint. Only that scope's org is returned.
  3. Log in as a non-staff user with an org-level glob role, e.g. over lib:Org1:* or course-v1:Org1+*, and call the same endpoint. Only that org is returned.
  4. Log in as a non-staff user with no course or library role assignments. No orgs are returned.
  5. Reproduce [Test failure] <TC-00619>: <AuthZ Organization Filter Displays Unauthorized Organizations for Org Staff Users> wg-build-test-release#612 against the Console directly. Log in as a user with an OrgStaffRole scoped to a single org, open the AuthZ Organization filter, and confirm only that org appears instead of every org on the platform.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 9, 2026
@openedx-webhooks

openedx-webhooks commented Jul 9, 2026

Copy link
Copy Markdown

Thanks for the pull request, @mariajgrimaldi!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

The org filter endpoint returned every active org regardless of the
requesting user's actual course/library role assignments. Now it's
limited to orgs the user has a role in (via specific or org-level glob
scopes), with staff/superusers still seeing everything.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filter-orgs-by-assignments branch from c92a357 to 0dce38b Compare July 10, 2026 12:01
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review July 10, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

[Test failure] <TC-00619>: <AuthZ Organization Filter Displays Unauthorized Organizations for Org Staff Users>

2 participants