feat!: ComponentVersionMedia.key -> ComponentVersionMedia.path - #547
Merged
Conversation
This was referenced Apr 15, 2026
kdmccormick
force-pushed
the
kdmccormick/keys-ref
branch
3 times, most recently
from
April 15, 2026 10:26
0b01361 to
52fe205
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
from
April 15, 2026 10:27
ca5d407 to
bb6edbd
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-ref
branch
from
April 16, 2026 20:48
52fe205 to
b9d11db
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
2 times, most recently
from
April 16, 2026 23:00
64d820e to
5c28c6f
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-ref
branch
from
April 17, 2026 16:43
09bbd04 to
3f23389
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
from
April 17, 2026 16:45
5c28c6f to
9bc8916
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-ref
branch
from
April 17, 2026 17:01
29580c7 to
3a446d5
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
from
April 17, 2026 17:05
9bc8916 to
88a3564
Compare
kdmccormick
marked this pull request as ready for review
April 17, 2026 17:59
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
2 times, most recently
from
April 17, 2026 18:28
39d0c53 to
72a9868
Compare
kdmccormick
commented
Apr 17, 2026
Comment on lines
-53
to
+55
| class ContentInline(admin.TabularInline): | ||
| class MediaInline(admin.TabularInline): | ||
| """ | ||
| Django admin configuration for Content | ||
| Django admin configuration for Media |
Member
Author
There was a problem hiding this comment.
Unrelated, just something I noticed
kdmccormick
force-pushed
the
kdmccormick/keys-ref
branch
from
April 17, 2026 18:48
28197b9 to
9d0ed28
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
from
April 17, 2026 18:48
72a9868 to
f00160d
Compare
ormsbee
approved these changes
Apr 17, 2026
|
|
||
|
|
||
| class ContentInline(admin.TabularInline): | ||
| class MediaInline(admin.TabularInline): |
Contributor
There was a problem hiding this comment.
Oops. I feel silly for missing that one.
Contributor
|
I won't review this PR; Dave's ✅ is good :) |
kdmccormick
force-pushed
the
kdmccormick/keys-ref
branch
2 times, most recently
from
April 21, 2026 15:27
1a51119 to
02c300d
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
2 times, most recently
from
April 21, 2026 15:36
8d11d63 to
f91dd6d
Compare
BREAKING CHANGE: Renamed ComponentVersionMedia.key -> ComponentVersionMedia.path
BREAKING CHANGE: In create_component_version_media(...) and
look_up_component_version_media(...), renamed param key -> path.
Part of: #322
Bumps version to 0.43.0
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
from
April 21, 2026 16:54
f91dd6d to
63f6356
Compare
kdmccormick
enabled auto-merge (squash)
April 21, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Renamed ComponentVersionMedia.key -> ComponentVersionMedia.path
BREAKING CHANGE: In create_component_version_media(...), renamed param key -> path.
BREAKING CHANGE: In look_up_component_version_media(...), renamed param key -> path.
Part of: #322
Full series of PRs:
keysare now opaquerefs#546Testing, AI Usage, and Merge Considerations
See #322