refactor: change base exception name to OpenEdxFilterException - #6
Merged
Conversation
Member
Author
|
This PR needs #10 for checks to be successful |
magajh
reviewed
Aug 18, 2021
magajh
reviewed
Aug 18, 2021
mariajgrimaldi
force-pushed
the
MJG/refactor_exception
branch
2 times, most recently
from
September 3, 2021 13:30
b564d38 to
b293942
Compare
mariajgrimaldi
force-pushed
the
MJG/refactor_exception
branch
from
September 3, 2021 13:54
b293942 to
ea8b914
Compare
magajh
reviewed
Sep 3, 2021
|
@mariajgrimaldi I noticed that in the run_pipeline function there is an argument called hook_name |
Member
Author
mariajgrimaldi
force-pushed
the
MJG/refactor_exception
branch
2 times, most recently
from
September 3, 2021 14:49
73a8d34 to
03f9aa4
Compare
magajh
self-requested a review
September 3, 2021 14:51
magajh
approved these changes
Sep 3, 2021
mariajgrimaldi
force-pushed
the
MJG/refactor_exception
branch
from
September 3, 2021 14:58
03f9aa4 to
a34021a
Compare
mariajgrimaldi
force-pushed
the
MJG/refactor_exception
branch
from
September 3, 2021 15:04
a34021a to
147216e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR renames HookFilterException to OpenEdxFilterException to be similar to OpenEdxEventsException
JIRA:
Part of repository refactor: https://edunext.atlassian.net/browse/PS2021-914?atlOrigin=eyJpIjoiYWVmODliMjAzNWMyNDM3NzlhNTY2NDVlZDcxMTE1NDciLCJwIjoiaiJ9