-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: consolidated pip-compile -> uv migration (all 5 stacked PRs, rebased onto master) #38915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
976bcef
8398493
3951ef3
3ba6641
f3aad4d
e438c12
599b970
ed5f8a5
138aafa
e495a60
d3f85f9
ed31316
9777414
362c94b
6d4d18a
a1d3ea1
1ac90a6
4ab40db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,18 +48,10 @@ jobs: | |
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Get pip cache dir | ||
| id: pip-cache-dir | ||
| run: | | ||
| echo "dir=$(pip cache dir)" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Cache pip dependencies | ||
| id: cache-dependencies | ||
| uses: actions/cache@v6 | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we pin this action to a commit SHA instead of @v7? We generally prefer immutable SHA-pinned GitHub Actions to improve supply chain security and reproducibility.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replied on the SHA-pinning question in a summary comment: #38915 (comment) |
||
| with: | ||
| path: ${{ steps.pip-cache-dir.outputs.dir }} | ||
| key: ${{ runner.os }}-pip-${{ hashFiles('requirements/edx/base.txt') }} | ||
| restore-keys: ${{ runner.os }}-pip- | ||
| enable-cache: true | ||
|
|
||
| - name: Install Required Python Dependencies | ||
| run: | | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,23 +24,15 @@ jobs: | |
| - name: Install system requirements | ||
| run: sudo apt update && sudo apt install -y libxmlsec1-dev | ||
|
|
||
| - name: Install pip | ||
| run: make pre-requirements | ||
|
|
||
| - name: Get pip cache dir | ||
| id: pip-cache-dir | ||
| run: echo "dir=$(pip cache dir)" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Cache pip dependencies | ||
| id: cache-dependencies | ||
| uses: actions/cache@v6 | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we pin this action to a commit SHA instead of @v7? We generally prefer immutable SHA-pinned GitHub Actions to improve supply chain security and reproducibility.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replied on the SHA-pinning question in a summary comment: #38915 (comment) |
||
| with: | ||
| path: ${{ steps.pip-cache-dir.outputs.dir }} | ||
| key: ${{ runner.os }}-pip-${{ hashFiles('requirements/edx/development.txt') }} | ||
| restore-keys: ${{ runner.os }}-pip- | ||
| enable-cache: true | ||
|
|
||
| - name: Install python dependencies | ||
| run: make dev-requirements | ||
| run: | | ||
| make dev-requirements | ||
| echo "$PWD/.venv/bin" >> "$GITHUB_PATH" | ||
|
|
||
| # As long there are sub-projects[1] in openedx-platform, we analyze each | ||
| # project separately here, in order to make import-linting errors easier | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you verify these paths? Previously, add-paths monitored the top-level requirements path. With this change, requirements* is only being added under scripts/. I just want to confirm this is the intended behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this is intended: the top-level
requirementsentry is unchanged from before this PR and still matches everything recursively underrequirements/, including the newrequirements/edx-sandbox/{pyproject.toml,uv.lock}standalone uv project. The newscripts/**/...and top-levelpyproject.toml/uv.lockentries are purely additive, for the new uv sub-projects that live outsiderequirements/.