feat: remove legacy library content block from component templates - #38930
feat: remove legacy library content block from component templates#38930salman2013 wants to merge 2 commits into
Conversation
Removes the 'library' template from the Studio add-component strip so that new LegacyLibraryContentBlock instances can no longer be created via the UI. - Removes 'library' from COMPONENT_TYPES - Removes 'library' display name entry from component_display_names - Removes the library block types loop (category == 'library') - Removes 'library' from component_not_supported_by_library - Removes the libraries_v1_enabled() filter from _filter_disabled_blocks Existing library_content blocks continue to work normally, including the randomized settings editor, "View all" container navigation, and migration to v2 libraries. Only creation of new blocks via the add-component UI is prevented. Refs: #38058 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for the pull request, @salman2013! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The approach looks good! Can you also confirm that the legacy library block doesn't show up under "Advanced" ? Please have someone else from Aximprovements review as well @salman2013 and then I'll approve and merge. |
Summary
librarytemplate from the Studio add-component strip, preventing creation of newLegacyLibraryContentBlockinstances via the UI'library'fromCOMPONENT_TYPES, its display name entry, the library block types loop, thecomponent_not_supported_by_librarylist, and thelibraries_v1_enabled()filter in_filter_disabled_blocksExisting
library_contentblocks are fully unaffected:Companion frontend PR: openedx/frontend-app-authoring#3180
Ticket: #38058
Test plan
library_contentblocks still render correctlyTesting Results