Skip to content

Fix inline validation errors on password update form - #5315

Merged
ajrbyers merged 4 commits into
r-v1.9.xfrom
b-4642-password-update-errors
Jul 30, 2026
Merged

Fix inline validation errors on password update form#5315
ajrbyers merged 4 commits into
r-v1.9.xfrom
b-4642-password-update-errors

Conversation

@ajrbyers

Copy link
Copy Markdown
Member

Closes #4642

@mauromsl mauromsl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor tidbit

Comment thread src/core/forms/forms.py
Comment thread src/core/forms/forms.py
@mauromsl mauromsl assigned ajrbyers and unassigned mauromsl May 27, 2026
@ajrbyers ajrbyers assigned mauromsl and unassigned ajrbyers May 28, 2026
@ajrbyers
ajrbyers requested a review from mauromsl July 30, 2026 09:31
@ajrbyers
ajrbyers changed the base branch from master to r-v1.9.x July 30, 2026 09:58
ajrbyers and others added 3 commits July 30, 2026 11:05
Wrap edit-profile password change in PasswordChangeForm so validation errors (current-password mismatch, confirmation mismatch, policy failures) render inline via the form errors partial and the page stays put on failure instead of redirecting with disappearing toasts. Adds the password_rules partial so requirements are visible upfront.
@ajrbyers
ajrbyers force-pushed the b-4642-password-update-errors branch from b5e86ab to dd18003 Compare July 30, 2026 10:10
@ajrbyers
ajrbyers merged commit fbfb3a7 into r-v1.9.x Jul 30, 2026
4 checks passed
@ajrbyers
ajrbyers deleted the b-4642-password-update-errors branch July 30, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password update: Users need informative and persistent messaging if password update fails due to not meeting requirements

2 participants