Potential fix for code scanning alert no. 31: Clear-text logging of sensitive information - #220
Draft
H-Sihan wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 31: Clear-text logging of sensitive information#220H-Sihan wants to merge 1 commit into
H-Sihan wants to merge 1 commit into
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/openshield-org/openshield/security/code-scanning/31
To fix this safely without changing functionality, keep the error handling behavior but stop logging raw
end_dt_str. Replace the current debug statement so it logs only non-sensitive context (for exampleapp_id) and a generic message indicating invalidendDateTimeformat. This preserves observability (you still know which app had bad data) while eliminating clear-text output of tainted credential-derived content.In
scanner/rules/az_idn_006.py, edit theexcept ValueError:block around lines 73–77:%rplaceholder andend_dt_strargumentapp_idin the log for correlationSuggested fixes powered by Copilot Autofix. Review carefully before merging.