Skip to content

[WIP] OCPCLOUD-3546: Promote CRDCompatibilityRequirementOperator feature gate to Default#2908

Draft
stefanonardo wants to merge 1 commit into
openshift:masterfrom
stefanonardo:OCPCLOUD-3546
Draft

[WIP] OCPCLOUD-3546: Promote CRDCompatibilityRequirementOperator feature gate to Default#2908
stefanonardo wants to merge 1 commit into
openshift:masterfrom
stefanonardo:OCPCLOUD-3546

Conversation

@stefanonardo

Copy link
Copy Markdown

Summary

  • Promote the CRDCompatibilityRequirementOperator feature gate from TechPreview/DevPreview to Default/OKD, making the CRD compatibility checker operator available on all default-configured clusters.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 29, 2026

Copy link
Copy Markdown

@stefanonardo: This pull request references OCPCLOUD-3546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Promote the CRDCompatibilityRequirementOperator feature gate from TechPreview/DevPreview to Default/OKD, making the CRD compatibility checker operator available on all default-configured clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3d1716cf-950c-481f-afdc-e16341ec7e6a

📥 Commits

Reviewing files that changed from the base of the PR and between 7841260 and 4e1d766.

⛔ Files ignored due to path filters (2)
  • config/v1/zz_generated.crd-manifests/0000_00_cluster-version-operator_01_clusterversions-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • config/v1/zz_generated.crd-manifests/0000_00_cluster-version-operator_01_clusterversions-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
📒 Files selected for processing (6)
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

📝 Walkthrough

Walkthrough

The CRDCompatibilityRequirementOperator feature gate is promoted from TechPreview/DevPreview-only to fully enabled across all profiles. In features/features.go, inDefault() and inOKD() are added to its enable(...) call. The features.md documentation table is updated to reflect all columns as Enabled. Four generated YAML manifests (featureGate-4-10-Hypershift-Default, featureGate-4-10-Hypershift-OKD, featureGate-4-10-SelfManagedHA-Default, featureGate-4-10-SelfManagedHA-OKD) move the gate from the disabled list to the enabled list.

Suggested reviewers

  • JoelSpeed
  • everettraven
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: promoting the CRDCompatibilityRequirementOperator feature gate to Default.
Description check ✅ Passed The description matches the changeset by stating the feature gate is promoted from preview levels to Default/OKD.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Touched files are docs/feature-gate code/manifests only; no Ginkgo It/Describe/Context/When titles were added or changed.
Test Structure And Quality ✅ Passed PASS: The PR changes are feature docs/manifests plus a plain testing.T parity test; no Ginkgo cluster tests or Eventually/cleanup issues were introduced.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the touched tests are unit/envtest scaffolding and don't reference MicroShift-unsupported APIs.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only changes feature-gate docs, manifests, and a feature registry entry, so SNO compatibility isn’t implicated.
Topology-Aware Scheduling Compatibility ✅ Passed Only feature-gate metadata/docs changed; no pod affinity, node selectors, replica, PDB, or topology-aware scheduling logic was added.
Ote Binary Stdout Contract ✅ Passed The changed code is feature metadata only; builder/init paths in features.go/util.go have no fmt/klog/log stdout writes or suite hooks.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only changes feature-gate docs/config and manifests; no new Ginkgo e2e tests or IPv4/external-network assumptions were added.
No-Weak-Crypto ✅ Passed Touched files only adjust feature-gate metadata; no weak ciphers, custom crypto, or secret/token comparisons appear in the diff.
Container-Privileges ✅ Passed Changed files are only feature-gate docs/manifests; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields appear.
No-Sensitive-Data-In-Logs ✅ Passed Changed files are feature-gate docs/manifests only; no log statements or sensitive data patterns appear in the touched code.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hello @stefanonardo! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed

Copy link
Copy Markdown
Contributor

/test verify-feature-promotion

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@stefanonardo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion 4e1d766 link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants