feat: Add konflux-kargo-bot bot to trusted applications for infra deployments#81377
feat: Add konflux-kargo-bot bot to trusted applications for infra deployments#81377flacatus wants to merge 1 commit into
Conversation
…loyments Signed-off-by: flacatus <flacatus@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flacatus The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThis PR updates the Prow trigger plugin configuration for the redhat-appstudio/infra-deployments repository, adding an org_invite rule and extending the trusted_apps list with an additional bot entry. ChangesTrigger Configuration Update
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
openshift-merge-bot
Bot
added
the
rehearsals-ack
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core-services/prow/02_config/redhat-appstudio/infra-deployments/_pluginconfig.yaml`:
- Around line 69-70: Remove the unsupported nested prominent field from the
org_invite trigger config so only the valid org_invite entry remains. Update the
_pluginconfig.yaml org_invite block to match the accepted trigger configuration
shape and ensure no extra keys are present under org_invite, since strict
validation will reject them.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: fe7ce14b-b695-4c8b-9fa1-39e94568dcd9
📒 Files selected for processing (1)
core-services/prow/02_config/redhat-appstudio/infra-deployments/_pluginconfig.yaml
| - org_invite: | ||
| prominent: {} |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🌐 Web query:
Does the Prow trigger plugin config support an "org_invite" field with a "prominent" option?
💡 Result:
The Prow trigger plugin configuration does not support an "org_invite" field with a "prominent" option [1][2]. While the "trigger" plugin configuration does contain an "org_invite" field (as seen in the plugins.OrgInviteConfig Go struct used in Prow's configuration package [1]), there is no "prominent" option associated with it [1][2]. The "org_invite" configuration generally relates to managing organization invitations [1], and existing documentation and source code definitions for Trigger and related structures do not define or reference a "prominent" setting [2].
Citations:
- 1: https://pkg.go.dev/sigs.k8s.io/prow/pkg/plugins
- 2: https://github.com/kubernetes-sigs/prow/blob/f6cc3990c368/pkg/plugins/config.go
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the local usage and surrounding context for org_invite/prominent.
git ls-files 'core-services/prow/02_config/redhat-appstudio/infra-deployments/_pluginconfig.yaml' \
'core-services/prow/**/_pluginconfig.yaml' \
'core-services/prow/**/plugin*.yaml' \
'core-services/prow/**/plugins*.yaml' | sed -n '1,200p'
echo
echo "=== org_invite occurrences ==="
rg -n --hidden --glob '!**/.git/**' 'org_invite|prominent' core-services prow ci-operator services cluster projects 2>/dev/null || true
echo
echo "=== surrounding lines from target file ==="
sed -n '55,90p' core-services/prow/02_config/redhat-appstudio/infra-deployments/_pluginconfig.yamlRepository: openshift/release
Length of output: 15364
🌐 Web query:
Prow trigger plugin org_invite prominent config.go prominent option
💡 Result:
There is no known prominent option or configuration parameter named prominent within the Prow trigger plugin or its configuration files (e.g., config.go) [1][2][3]. Regarding the org_invite functionality, it is a feature within Prow that prompts contributors to join an organization after they have met a specific threshold of merged pull requests [4]. As of April 2026, this feature has been a subject of discussion regarding making it configurable [4]. Suggested configuration patterns for this functionality have been proposed to include fields such as [4]: disabled: (bool) To enable or disable the invitation. merged_pr_threshold: (int) To specify how many PRs a contributor must have merged before receiving the invite. org_join_guidelines: (string) A URL pointing to contribution guidelines. message: (string) A custom template for the invitation message. These configurations are intended to be implemented within a substruct (e.g., org_invite) inside the trigger plugin configuration to avoid mixing these settings with existing test trigger configurations [4]. As of the current date, you should refer to the latest documentation in pkg/plugins/config.go or the official Prow plugin configuration guides to verify if these specific fields have been merged into the main codebase [1][5].
Citations:
- 1: https://github.com/kubernetes-sigs/prow/blob/f6cc3990c368/pkg/plugins/config.go
- 2: https://pkg.go.dev/sigs.k8s.io/prow/pkg/plugins
- 3: https://pkg.go.dev/sigs.k8s.io/prow/pkg/plugins/trigger
- 4: Make org invite functionality configurable kubernetes-sigs/prow#670
- 5: https://docs.prow.k8s.io/docs/components/plugins/_print/
Drop the nested prominent key from org_invite. org_invite is valid here, but prominent: {} is not a supported trigger config field and will fail strict config validation. core-services/prow/02_config/redhat-appstudio/infra-deployments/_pluginconfig.yaml:69-70
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@core-services/prow/02_config/redhat-appstudio/infra-deployments/_pluginconfig.yaml`
around lines 69 - 70, Remove the unsupported nested prominent field from the
org_invite trigger config so only the valid org_invite entry remains. Update the
_pluginconfig.yaml org_invite block to match the accepted trigger configuration
shape and ensure no extra keys are present under org_invite, since strict
validation will reject them.
|
@flacatus: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
…
Summary by CodeRabbit
This change updates the trusted app configuration for the
redhat-appstudio/infra-deploymentsrepository in OpenShift CI sokonflux-kargo-botcan be used for infrastructure deployment automation. It expands the set of approved applications that can interact with this repo’s trusted trigger flow, while keeping the existing trusted bots in place.