DNM: Test OTE test rebasebot integration

[mdbooth]

Tests OTE rebasebot integration in openshift/cloud-provider-gcp#121

I have manually created https://github.com/mdbooth/cloud-provider-gcp/tree/rebase-test. This is cloud-provider-gcp from release-4.21 + the 2 commits from openshift/cloud-provider-gcp#121 which add the OTE and the rebasebot integration, and the following 3 carry patches removed:

• UPSTREAM: : Reuse instance-groups for internal load balancers
• UPSTREAM: : Fix OSD ILB bug
• UPSTREAM: 911: allow users to manage their own firewall rules

The reason for removing these 3 carry patches is that they required manual fixes when we did this for real. This isn't the focus of this test, so they're removed.

The test invocation rebases this branch on the upstream master branch.

We expect that:

• the CCM rebase itself is unaffected, it builds correctly
• the deps in openshift-tests are bumped to match, and it builds correctly

Summary by CodeRabbit

Updates the OpenShift cloud-provider-gcp rebasebot periodic CI job so it now uses the test branch/image pair for the OTE rebasebot integration flow. In practical terms, this switches the rebasebot input from the mainline branch to the manually prepared rebase-test setup and moves post-rebase dependency updates into the built-in go-modules update hook, matching the expected rebasebot test behavior for the cloud-provider-gcp repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2a9fc33d-7138-4013-b543-48711f35ecae

📥 Commits

Reviewing files that changed from the base of the PR and between 6ec9779 and 85c44f2.

📒 Files selected for processing (1)

• ci-operator/config/openshift/cloud-provider-gcp/openshift-cloud-provider-gcp-main__periodics.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/openshift/cloud-provider-gcp/openshift-cloud-provider-gcp-main__periodics.yaml

---

Walkthrough

This change updates a CI periodic rebasebot configuration by changing the destination and rebase image tags and replacing the direct go-modules update flag with a post-rebase hook.

Changes

Rebasebot Config Update

Layer / File(s)	Summary
Rebasebot arguments update ci-operator/config/openshift/cloud-provider-gcp/openshift-cloud-provider-gcp-main__periodics.yaml	The rebasebot job now targets mdbooth/cloud-provider-gcp:rebase-test, reuses openshift-cloud-team/cloud-provider-gcp:rebase-bot-mdbooth-test, and runs _BUILTIN_/update_go_modules.sh via --post-rebase-hook instead of --update-go-modules.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: rehearsals-ack

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is clearly related to the PR’s main purpose: testing OTE/rebasebot integration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only edits a ci-operator YAML rebasebot command; no Ginkgo test titles or dynamic test names were added or changed.
Test Structure And Quality	✅ Passed	No Ginkgo test code was changed; touched tests are plain Go unit tests, so the Ginkgo-specific quality check is not applicable.
Microshift Test Compatibility	✅ Passed	PASS: This PR only edits a ci-operator periodic rebasebot YAML; it adds no Ginkgo e2e tests or OpenShift API usage to evaluate for MicroShift.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only CI rebasebot periodic config changed; no Ginkgo test files or test logic were added, so SNO compatibility is not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a ci-operator periodic command changed; no deployment manifests, controllers, affinity, nodeSelector, or topology-aware scheduling logic were introduced.
Ote Binary Stdout Contract	✅ Passed	Only the ci-operator periodic YAML changed; no process-level OTE code (main/TestMain/BeforeSuite/init) was modified, so no stdout contract issue.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only updates a ci-operator periodic YAML for rebasebot; no new Ginkgo e2e tests or test code were added, so IPv4/disconnected compatibility is not implicated.
No-Weak-Crypto	✅ Passed	Only a ci-operator rebasebot config changed; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-comparison code was added.
Container-Privileges	✅ Passed	The changed periodic ci-operator YAML only updates rebasebot command args; it contains no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only edits CI rebasebot args; no log statements or secret values were added, just secret file paths and a bot email.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdbooth
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cloud-provider-gcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

/pj-rehearse

[openshift-merge-bot]

@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mdbooth]

(GH permissions issue)

/pj-rehearse

[openshift-merge-bot]

@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mdbooth]

/pj-rehearse

[openshift-merge-bot]

@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@mdbooth: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-cloud-provider-gcp-main-periodics-rebasebot	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.