[OSPRH-32283] Make polling.yaml dynamic based on enabled services - #947
Conversation
|
Build failed (check pipeline). Post ❌ telemetry-openstack-meta-content-provider-master FAILURE in 16m 31s |
3a2d595 to
88040d9
Compare
|
Build failed (check pipeline). Post ❌ telemetry-openstack-meta-content-provider-master FAILURE in 19m 14s |
|
recheck |
|
Build failed (check pipeline). Post ❌ telemetry-openstack-meta-content-provider-master FAILURE in 19m 46s |
4a7ce70 to
5662a67
Compare
| Watches( | ||
| &keystonev1.KeystoneEndpoint{}, | ||
| handler.EnqueueRequestsFromMapFunc(keystoneEndpointsWatchFn), | ||
| handler.EnqueueRequestsFromMapFunc(r.findObjectForSrc), |
There was a problem hiding this comment.
r.findObjectForSrc is functionally almost the same as keystoneEndpointWatchFn. The difference is, that keystoneEndpointsWatchFn reconciled only the ceilometer.ServiceName named ceilometer. While r.findObjectForSrc reconciles all ceilometer CRs in a given namespace, making it independent on the CR name. This is more correct and it's needed for kuttl tests to work, since the ceilometer there is called telemetry-kuttl.
5662a67 to
05629cc
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
05629cc to
599cecd
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck seems to me like github or zuul is having some issues |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Build failed (check pipeline). Post ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 46m 53s |
|
recheck Failed to download packages: tmux-3.2a-5.el9.x86_64 |
| _, err := keystonev1.GetKeystoneEndpointWithName(ctx, h, endpointName, namespace) | ||
| if err != nil { | ||
| if !k8s_errors.IsNotFound(err) { | ||
| log.Info("Failed to check for KeystoneEndpoint, assuming not present", |
There was a problem hiding this comment.
Minor, but shouldnt this be a log.Error trace?
There was a problem hiding this comment.
I wasn't sure which level would be better. IIRC we've historically gravitated more towards the less severe error levels. But you're right that this situation kind of sounds like an error. I'll switch it to error 👍
599cecd to
e979c6a
Compare
The ceilometer central agent's polling.yaml will change dynamically and include Designate, Octavia or Manila polling configuration if these services are enabled. The mechanism is watching the KeystoneEndpoint CRs to determine whether these services are enabled. This means we don't need to add any new watches (like watching the Octavia CR) and we don't need any new dependencies (like the octavia-operator). This works very similar to how swift polling config worked until now. Also ceilometer would already restart on each new KeystoneEndpoint, so there isn't any additional reconciling / pod restarts compared to the previous behavior. Generated-By: Claude-Code claude-opus-4-6
e979c6a to
3685838
Compare
|
/retest |
|
Build failed (check pipeline). Post ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 48m 48s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 3h 02m 53s |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlarriba, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick 18-stable |
|
@vyzigold: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7c618ec
into
openstack-k8s-operators:main
|
@vyzigold: new pull request created: #970 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
The ceilometer central agent's polling.yaml will change dynamically and include Designate, Octavia or Manila polling configuration if these services are enabled. The mechanism is watching the KeystoneEndpoint CRs to determine whether these services are enabled. This means we don't need to add any new watches (like watching the Octavia CR) and we don't need any new dependencies (like the octavia-operator). This works very similar to how swift polling config worked until now. Also ceilometer would already restart on each new KeystoneEndpoint anyway, so there isn't any additional reconciling / pod restarts compared to the previous behavior.
Generated-By: Claude-Code claude-opus-4-6