[OSPRH-33382] Generate telemetry_secret per-deployment instead of har… - #969
Open
jlarriba wants to merge 1 commit into
Open
[OSPRH-33382] Generate telemetry_secret per-deployment instead of har…#969jlarriba wants to merge 1 commit into
jlarriba wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlarriba The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…dcoded literal The Ceilometer publisher telemetry_secret was hardcoded as a static literal in three config templates (central, compute, ipmi), meaning every deployment shared the same publicly known HMAC key. This replaces it with a per-deployment random value generated on first reconcile and persisted via CreateOrPatchSecretPreserve, following the same pattern used for other templated secrets in the operator. Signed-off-by: Juan Larriba <jlarriba@redhat.com>
jlarriba
force-pushed
the
OSPRH-33382-template-telemetry-secret
branch
from
July 30, 2026 10:29
0710d0a to
504b356
Compare
Collaborator
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dcoded literal
The Ceilometer publisher telemetry_secret was hardcoded as a static literal in three config templates (central, compute, ipmi), meaning every deployment shared the same publicly known HMAC key. This replaces it with a per-deployment random value generated on first reconcile and persisted via CreateOrPatchSecretPreserve, following the same pattern used for other templated secrets in the operator.