Conversation
- Rename trad_auth to traditional_authority - Rename structure_type to well_structure_type - Rename structure_type_other to well_structure_type_other - Rename fill_time_20l to seconds_to_fill_20L - Rename community_use to use_of_site
…cumentation - Remove ggplot2 and maps packages (not needed for data processing) - Add descriptive comments explaining each processing step - Document the purpose of each data export format - Note final dataset dimensions (44 wells, 29 variables)
Fix Issue #3: Data Content & Processing
- Create R-CMD-check.yaml workflow to test on multiple R versions and OS - Configure to run on push and PR to main, master, and dev branches - Add R-CMD-check badge to README.Rmd - Test on Ubuntu (release, oldrel, devel), macOS, and Windows
- Add examples showing how to load and explore the dataset - Include examples for viewing data, checking dimensions, and summarizing districts - Regenerate documentation with devtools::document() - All examples tested and working correctly
Fix Issue #5: Tests & CI/CD
- Add placeholder ORCID ID (0000-0000-0000-0000) for @emmanuellmhango - Add missing package dependencies: readr, dplyr, readxl, openxlsx - These packages are used in data_processing.R @emmanuellmhango Please update with your actual ORCID ID
- Add CITATION.cff following CFF v1.2.0 format - Add inst/CITATION for R package citation - Include placeholder ORCID ID pending update from @emmanuellmhango - Set up proper citation structure for future DOI integration
- Replace placeholder ORCID (0000-0000-0000-0000) with actual ORCID (0000-0003-3197-6244) - Update ORCID in DESCRIPTION and CITATION.cff - Fix year in inst/CITATION from 2024 to 2025 to match CITATION.cff date
Fix Issue #2: General Information & Metadata
- Create _pkgdown.yml with openwashdata template and Plausible analytics - Fix license link in README.Rmd (removed placeholder) - Update Roxygen documentation variable names to match dictionary.csv - Regenerate documentation and README.md - Successfully build pkgdown site
…tation Fix Issue #4: Documentation
Contributor
|
Dear @emmanuellmhango, thank you for preparing the artesianwells data package - this valuable dataset documenting 44 artesian well sites across Malawi will support water resource planning and research. The package has passed all review checks and is ready to be merged to main for publication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Colin
Kindly review the pull request. I have done the following:
Kindly note that i pushed to the DEV branch before initialized the main branch.
Kind regards