Remove unused public function connection on stores

[DanielBadura]

No description provided.

[github-actions]

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBatchBench
============================

+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                     | memory                                     |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 117.523ms (±0.00%) | 115.701ms (±0.00%) | +1.57%    | 35.720mb        | 36.240mb   | -1.43%      |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

NoopSubscriptionEngineBench
===========================

+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                     | memory                                     |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 105.184ms (±0.00%) | 110.343ms (±0.00%) | -4.68%    | 48.296mb        | 48.296mb   | 0.00%       |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 3.435ms (±0.00%)   | 3.451ms (±0.00%)   | -0.47%    | 35.769mb        | 35.769mb   | 0.00%       |
| benchSave10000Events () | 512.709ms (±0.00%) | 535.428ms (±0.00%) | -4.24%    | 35.904mb        | 35.904mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.328ms (±0.00%)   | 1.104ms (±0.00%)   | +20.27%   | 35.141mb        | 35.141mb   | 0.00%       |
| benchLoad10000Events ()                | 74.210ms (±0.00%)  | 72.933ms (±0.00%)  | +1.75%    | 35.141mb        | 35.141mb   | 0.00%       |
| benchSave1Event ()                     | 1.244ms (±0.00%)   | 1.140ms (±0.00%)   | +9.11%    | 35.141mb        | 35.141mb   | 0.00%       |
| benchSave10000Events ()                | 292.413ms (±0.00%) | 305.165ms (±0.00%) | -4.18%    | 35.141mb        | 35.141mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.835s (±0.00%)    | 8.862s (±0.00%)    | -0.30%    | 35.141mb        | 35.141mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.794s (±0.00%)    | 5.788s (±0.00%)    | +0.10%    | 35.141mb        | 35.141mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupTaggableStoreBench
=============================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.178ms (±0.00%)   | 1.117ms (±0.00%)   | +5.49%    | 36.306mb        | 36.306mb   | 0.00%       |
| benchLoad10000Events ()                | 77.054ms (±0.00%)  | 77.740ms (±0.00%)  | -0.88%    | 36.306mb        | 36.306mb   | 0.00%       |
| benchSave1Event ()                     | 1.296ms (±0.00%)   | 1.339ms (±0.00%)   | -3.24%    | 36.306mb        | 36.306mb   | 0.00%       |
| benchSave10000Events ()                | 320.074ms (±0.00%) | 319.000ms (±0.00%) | +0.34%    | 36.306mb        | 36.306mb   | 0.00%       |
| benchSave10000Aggregates ()            | 9.015s (±0.00%)    | 8.750s (±0.00%)    | +3.04%    | 36.307mb        | 36.307mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.856s (±0.00%)    | 5.848s (±0.00%)    | +0.13%    | 36.307mb        | 36.307mb   | 0.00%       |
| benchAppend1Event ()                   | 1.431ms (±0.00%)   | 1.664ms (±0.00%)   | -13.97%   | 36.306mb        | 36.306mb   | 0.00%       |
| benchAppend100Events ()                | 7.691ms (±0.00%)   | 7.612ms (±0.00%)   | +1.04%    | 36.306mb        | 36.306mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.527s (±0.00%) | 3.549s (±0.00%) | -0.62%    | 48.296mb        | 48.296mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 76.461ms (±0.00%) | 73.598ms (±0.00%) | +3.89%    | 35.146mb        | 35.146mb   | 0.00%       |
| benchLoad10000Events ()                | 1.223ms (±0.00%)  | 1.134ms (±0.00%)  | +7.88%    | 35.145mb        | 35.145mb   | 0.00%       |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 4.150ms (±0.00%) | 4.228ms (±0.00%) | -1.85%    | 5.464mb         | 4.995mb    | +9.39%      |
| benchUpdate () | 5.321ms (±0.00%) | 5.208ms (±0.00%) | +2.17%    | 5.072mb         | 5.072mb    | 0.00%       |
| benchBoth ()   | 8.229ms (±0.00%) | 8.484ms (±0.00%) | -3.01%    | 5.070mb         | 5.206mb    | -2.62%      |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.349ms (±0.00%)   | 1.384ms (±0.00%)   | -2.50%    | 35.805mb        | 35.805mb   | 0.00%       |
| benchLoad10000Events ()                | 112.565ms (±0.00%) | 109.792ms (±0.00%) | +2.53%    | 35.805mb        | 35.805mb   | 0.00%       |
| benchSave1Event ()                     | 2.014ms (±0.00%)   | 2.046ms (±0.00%)   | -1.56%    | 35.805mb        | 35.805mb   | 0.00%       |
| benchSave10000Events ()                | 333.527ms (±0.00%) | 331.821ms (±0.00%) | +0.51%    | 35.807mb        | 35.807mb   | 0.00%       |
| benchSave10000Aggregates ()            | 13.654s (±0.00%)   | 13.649s (±0.00%)   | +0.04%    | 35.805mb        | 35.805mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 10.501s (±0.00%)   | 10.480s (±0.00%)   | +0.20%    | 36.045mb        | 36.045mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

[DavidBadura]

I would like to keep the methods because I find them useful.

[DanielBadura]

Ok, I'll then open another PR which adds an interface so that you can better use these methods