Add many missing Unit-Tests by DanielBadura · Pull Request #877 · patchlevel/event-sourcing

DanielBadura · 2026-07-17T12:57:25Z

This uncovered 2 issues:

SubscriptionRemoveCommand was missing the parent call on configure (needs a fix in 3.x too)
AttributeEventTagExtractor was converting numeric strings into int by using array_keys, we need to cast it to string again.

github-actions · 2026-07-17T13:09:40Z

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBatchBench
============================

+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                     | memory                                     |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 108.525ms (±0.00%) | 107.109ms (±0.00%) | +1.32%    | 35.720mb        | 36.240mb   | -1.43%      |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

NoopSubscriptionEngineBench
===========================

+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                     | memory                                     |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 100.820ms (±0.00%) | 104.432ms (±0.00%) | -3.46%    | 48.296mb        | 48.296mb   | 0.00%       |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 3.502ms (±0.00%)   | 3.439ms (±0.00%)   | +1.82%    | 35.769mb        | 35.769mb   | 0.00%       |
| benchSave10000Events () | 496.828ms (±0.00%) | 518.277ms (±0.00%) | -4.14%    | 35.904mb        | 35.904mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.419ms (±0.00%)   | 1.184ms (±0.00%)   | +19.89%   | 35.141mb        | 35.141mb   | 0.00%       |
| benchLoad10000Events ()                | 71.555ms (±0.00%)  | 71.321ms (±0.00%)  | +0.33%    | 35.141mb        | 35.141mb   | 0.00%       |
| benchSave1Event ()                     | 1.181ms (±0.00%)   | 1.023ms (±0.00%)   | +15.45%   | 35.141mb        | 35.141mb   | 0.00%       |
| benchSave10000Events ()                | 290.239ms (±0.00%) | 284.553ms (±0.00%) | +2.00%    | 35.141mb        | 35.141mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.706s (±0.00%)    | 7.661s (±0.00%)    | +0.58%    | 35.141mb        | 35.141mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.844s (±0.00%)    | 4.855s (±0.00%)    | -0.21%    | 35.141mb        | 35.141mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupTaggableStoreBench
=============================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.223ms (±0.00%)   | 1.167ms (±0.00%)   | +4.78%    | 36.306mb        | 36.306mb   | 0.00%       |
| benchLoad10000Events ()                | 75.870ms (±0.00%)  | 72.769ms (±0.00%)  | +4.26%    | 36.306mb        | 36.306mb   | 0.00%       |
| benchSave1Event ()                     | 1.194ms (±0.00%)   | 1.219ms (±0.00%)   | -2.07%    | 36.306mb        | 36.306mb   | 0.00%       |
| benchSave10000Events ()                | 319.618ms (±0.00%) | 328.540ms (±0.00%) | -2.72%    | 36.306mb        | 36.306mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.558s (±0.00%)    | 7.633s (±0.00%)    | -0.98%    | 36.307mb        | 36.307mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.919s (±0.00%)    | 4.935s (±0.00%)    | -0.32%    | 36.307mb        | 36.307mb   | 0.00%       |
| benchAppend1Event ()                   | 1.346ms (±0.00%)   | 1.606ms (±0.00%)   | -16.19%   | 36.306mb        | 36.306mb   | 0.00%       |
| benchAppend100Events ()                | 7.380ms (±0.00%)   | 7.906ms (±0.00%)   | -6.65%    | 36.306mb        | 36.306mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.238s (±0.00%) | 3.265s (±0.00%) | -0.82%    | 48.296mb        | 48.296mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 71.401ms (±0.00%) | 71.997ms (±0.00%) | -0.83%    | 35.146mb        | 35.146mb   | 0.00%       |
| benchLoad10000Events ()                | 1.227ms (±0.00%)  | 1.188ms (±0.00%)  | +3.23%    | 35.145mb        | 35.145mb   | 0.00%       |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 4.146ms (±0.00%) | 4.354ms (±0.00%) | -4.76%    | 5.464mb         | 4.995mb    | +9.39%      |
| benchUpdate () | 5.235ms (±0.00%) | 5.118ms (±0.00%) | +2.28%    | 5.072mb         | 5.072mb    | 0.00%       |
| benchBoth ()   | 8.034ms (±0.00%) | 8.656ms (±0.00%) | -7.18%    | 5.070mb         | 5.206mb    | -2.62%      |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.394ms (±0.00%)   | 1.414ms (±0.00%)   | -1.42%    | 35.805mb        | 35.805mb   | 0.00%       |
| benchLoad10000Events ()                | 102.011ms (±0.00%) | 104.398ms (±0.00%) | -2.29%    | 35.805mb        | 35.805mb   | 0.00%       |
| benchSave1Event ()                     | 1.851ms (±0.00%)   | 1.958ms (±0.00%)   | -5.46%    | 35.805mb        | 35.805mb   | 0.00%       |
| benchSave10000Events ()                | 316.529ms (±0.00%) | 318.069ms (±0.00%) | -0.48%    | 35.807mb        | 35.807mb   | 0.00%       |
| benchSave10000Aggregates ()            | 11.816s (±0.00%)   | 11.777s (±0.00%)   | +0.33%    | 35.805mb        | 35.805mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.029s (±0.00%)    | 9.055s (±0.00%)    | -0.28%    | 36.045mb        | 36.045mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

… not covered by an interface

… by array_keys -> string cast needed there to be sure it is a string Add Unit tests for Serializer

DanielBadura added 11 commits July 17, 2026 17:38

Remove unused public function connection on stores which where also…

9eacdbb

… not covered by an interface

Add missing tests for StreamDoctrineDbalStore

26faee4

Add missing test for invalid stream name exception

e2a9d4f

Add missing Attribute tests

ebf532d

Add missing command bus tests

c8325b7

Add missing command tests

1043320

Fix missing call to parent construct

75751f9

Add missing cipher key store unit test

07e5256

Add missing Message context unit tests

58cbd3e

Add more metadata unit tests

6bc7857

Bump patchlevel/hydrator to latest v1 version

a79d6f2

DanielBadura force-pushed the add-more-unit-tests branch from df9e671 to a79d6f2 Compare July 17, 2026 15:38

DanielBadura added 2 commits July 17, 2026 18:06

Remove symlink test

f55dc78

Add Projection unit tests

1c49997

DanielBadura force-pushed the add-more-unit-tests branch 2 times, most recently from dd93a21 to 1c49997 Compare July 17, 2026 16:14

DanielBadura added 9 commits July 17, 2026 18:23

Add more QueryBus unit tests

a1300b1

Add more Repository unit tests

88641c9

Add DoctrineHelper unit tests

634f0dd

Fix a bug in the event tag extractor: numbers will be autocast to int…

7187063

… by array_keys -> string cast needed there to be sure it is a string Add Unit tests for Serializer

Add more cases for snapshot store

defda8f

Add more Store unit tests, VO, exceptions etc

3cc4adb

Add alot of subscription unit tests: most vo, exceptions etc

7db149f

Increase MSI to 90%

70848fa

Fix cs

47d69e1

DanielBadura changed the title ~~Add alot of unit tests~~ Add many missing Unit-Tests Jul 17, 2026

DanielBadura marked this pull request as ready for review July 17, 2026 18:30

DanielBadura self-assigned this Jul 17, 2026

DanielBadura requested a review from DavidBadura July 17, 2026 18:30

DanielBadura added bug Something isn't working enhancement New feature or request labels Jul 17, 2026

DanielBadura added this to the 4.0.0 milestone Jul 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add many missing Unit-Tests#877

Add many missing Unit-Tests#877
DanielBadura wants to merge 22 commits into
4.0.xfrom
add-more-unit-tests

DanielBadura commented Jul 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

DanielBadura commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

DanielBadura commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading